Skip to content

Make Evapotranspiration differentiable and vectorized#78

Merged
SCiarella merged 47 commits intomainfrom
evapo
Feb 24, 2026
Merged

Make Evapotranspiration differentiable and vectorized#78
SCiarella merged 47 commits intomainfrom
evapo

Conversation

@SCiarella
Copy link
Collaborator

@SCiarella SCiarella commented Jan 19, 2026

Closes #44.

@SCiarella SCiarella marked this pull request as ready for review February 17, 2026 11:10
SarahAlidoost
SarahAlidoost requested changes Feb 18, 2026
View reviewed changes
Copy link
Collaborator

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SCiarella thanks, looks very good, great to see how you cleaned up the classes by defining base classes 👍 I left some suggestions mostly about docstring and missing in-line comments. My main concerns are related to these:

  • implementing sSTE method with sigmoid insted of the cubic smoothstep,
  • adding more parameters to tests of gradients
  • implementing finalize method
  • implementing dvs mask

please see my comments for details. If something isnot clear, let me know and we can discuss it offline.

SarahAlidoost
SarahAlidoost requested changes Feb 18, 2026
View reviewed changes
Copy link
Collaborator

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SCiarella thanks, looks very good, great to see how you cleaned up the classes by defining base classes 👍 I left some suggestions mostly about docstring and missing in-line comments. My main concerns are related to these:

  • implementing STE method with sigmoid insted of the cubic smoothstep,
  • adding more parameters to tests of gradients
  • implementing finalize method
  • implementing dvs mask

please see my comments for details. If something isnot clear, let me know and we can discuss it offline.

SCiarella and others added 19 commits February 23, 2026 09:58
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
81a0722 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
4dacae1 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
7479da8 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
5464c14 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
21a1fb5 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
8072a86 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
7a1b6a7 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
8ae4803 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
4e1bcca 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
c15f34d 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
bee0bfa 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
7f1d861 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
0436866 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
9ff15d3 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
649bb70 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
da78b0a 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
fd859ae 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
10354b1 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
0a30b67 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
SCiarella and others added 14 commits February 23, 2026 11:15
@SCiarella
Use dvs_mask
e890e26
@SCiarella
remove TRALY from base
0e33304
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
ce78e03 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella
Add finalize method
5c5c3f1
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
b03effb 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
3036a77 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
a739166 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
147f9a8 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
16f1acf 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
65325a5 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
c07977a 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
3b6393c 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella
Fix
5eaf237
@SCiarella
Add missing tests
3aa7c4c
@SCiarella
Copy link
Collaborator Author

SCiarella commented Feb 23, 2026

Thanks a lot @SarahAlidoost for the careful review!

I have implemented all your suggestions, in particular:

  • we now use STE+sigmoid to differentiate the step function (same as leaf)
  • we test all the parameters combination for the gradient
  • implemented a finalize method like in the pcse version
  • we use dvs_mask like in the other modules

I have addressed and closed all the review comments that you left, except for a couple of minor comments that I did not fully understand, so please update that if they are still relevant after the revision.

SarahAlidoost
SarahAlidoost reviewed Feb 23, 2026
View reviewed changes
SarahAlidoost
SarahAlidoost reviewed Feb 23, 2026
View reviewed changes
SarahAlidoost
SarahAlidoost reviewed Feb 23, 2026
View reviewed changes
SarahAlidoost
SarahAlidoost reviewed Feb 23, 2026
View reviewed changes
SarahAlidoost
SarahAlidoost approved these changes Feb 23, 2026
View reviewed changes
Copy link
Collaborator

@SarahAlidoost SarahAlidoost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SCiarella Awesome! thanks for addressing the comments. Looks very good! 👍 only some suggestions on the docstring. I noticed some units are not the same as pcse code, see my suggestions. After applying those, let's merge this PR for now.

P.S. I'm not sure why in pcse there are different types for one variable for example SCr and S for the variable CFET. We can check this in our update meeting.

SCiarella and others added 5 commits February 24, 2026 09:24
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
cbc337a 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
ae0bf1b 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
b627a27 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
0c88073 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella @SarahAlidoost
Update src/diffwofost/physical_models/crop/evapotranspiration.py
99e148c 
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SCiarella SCiarella merged commit f55995e into main Feb 24, 2026
10 checks passed
@SCiarella SCiarella deleted the evapo branch February 24, 2026 08:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 24, 2026

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task]: Make Evapotranspiration differentiable and efficient

2 participants

@SCiarella @SarahAlidoost